fix(dracut.sh): --sysroot option broken if global variables not set in conf #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n conf When `$dracutsysrootdir` is set and references an existing directory, the internal global variables are never set, unless their value is assigned via configuration file. The simple fix would be turn all: ``` [[ -d $dracutsysrootdir$var ]] || var=value ``` into: ``` [[ -z $var || ! -d $dracutsysrootdir$var ]] && var=value ``` But this patch also includes a refactoring, removing duplicate code using the same `set_global_var` function to set and export global variables, and improving readability.
aafeijoo-suse
requested review from
haraldh,
danimo and
johannbg
as code owners
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
$dracutsysrootdiris set and references an existing directory, the internal global variables are never set, unless their value is assigned via configuration file (first reported in stalled PR #1975).The simple fix would be turn all:
into:
But this patch also includes a refactoring, removing duplicate code using the same
set_global_varfunction to set and export global variables, and improving readability.Checklist